-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Use correct, new transactions backup key for Money Request amounts #40605
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Checking if @DylanDylann and @cubuspl42 can review this, since this is a fix to their PR #39144 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-04-20.at.12.43.32.AM.movAndroid: mWeb ChromeScreen.Recording.2024-04-20.at.12.41.49.AM.moviOS: NativeScreen.Recording.2024-04-20.at.12.45.17.AM.moviOS: mWeb SafariScreen.Recording.2024-04-20.at.12.38.52.AM.movMacOS: Chrome / SafariScreen.Recording.2024-04-20.at.12.30.52.AM.movScreen.Recording.2024-04-20.at.12.30.16.AM.movMacOS: DesktopScreen.Recording.2024-04-20.at.12.36.11.AM.movScreen.Recording.2024-04-20.at.12.36.27.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good!
[CP Staging] Use correct, new transactions backup key for Money Request amounts (cherry picked from commit c1827d8)
…g-40605-1 🍒 Cherry pick PR #40605 to staging 🍒
I think this got to staging in #40609 and https://github.com/Expensify/App/actions/runs/8760659193 |
Yep i see it here - App/src/pages/iou/request/step/IOURequestStepAmount.tsx Lines 187 to 192 in e4a1a6e
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀
|
Details
See my comment here: #39144 (comment)
Fixed Issues
$ #40543
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop